WIP fix: only ship one transpile of typescript packages, and do not use package.json:exports #8848
+108
−296
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
this will be reused in other flows to create local packages prior to testing, for use in the testing
releasing two versions raises the risk of different instances loading for people using requires vs import, and implies special tricks using packages exports - and adding package exports is potentially breaking unless done perfectly this gets rid of the need for package exports and eliminates the risk of loading both ESM and CJS transpiles
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
mikehardy
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
A large part of the regression in v23.8.x appears to be related to using package.json:exports and two typescript transpiles
This PR attempts to reduce the shipped transpile of typescript packages to a single ESM transpile, and eliminates the use of package.json:exports in favor of the old-fashioned single
mainexport styleRelated issues
I believe this will be the last major fix required to close out the regressions on v23.8.x
Release Summary
Will be a fix release
Checklist
AndroidiOSOther(macOS, web)e2etests added or updated inpackages/\*\*/e2ejesttests added or updated inpackages/\*\*/__tests__Test Plan
Currently e2e tests pass locally, but jest is failing. Still working on that
Think
react-native-firebaseis great? Please consider supporting the project with any of the below:React Native FirebaseandInvertaseon Twitter